[ 
https://issues.apache.org/jira/browse/HDFS-17685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17904135#comment-17904135
 ] 

ASF GitHub Bot commented on HDFS-17685:
---------------------------------------

charlesconnell commented on code in PR #7215:
URL: https://github.com/apache/hadoop/pull/7215#discussion_r1875925407


##########
hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml:
##########
@@ -3444,6 +3444,16 @@
     </description>
   </property>
 
+  <property>
+    <name>dfs.client.lease.renewal.interval.ms</name>
+    <value>0</value>
+    <description>
+      If set between 0 and 30000 inclusive, HDFS clients will renew leases for 
files they are writing at this interval.
+      If dfs.client.lease.renewal.interval.ms is not set and 
ipc.client.rpc-timeout.ms is set between 0 and 60000,

Review Comment:
   It comes from existing behavior, yes. The lease renewal interval isn't 
allowed to be longer than half of the NameNode's timeout, which is hard-coded 
at 60 seconds.





> Option to explicitly choose DFS client lease renewal interval
> -------------------------------------------------------------
>
>                 Key: HDFS-17685
>                 URL: https://issues.apache.org/jira/browse/HDFS-17685
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: dfsclient
>            Reporter: Charles Connell
>            Priority: Minor
>              Labels: pull-request-available
>
> Currently, DFSClients send lease renewals to the NameNode at an interval 
> equal to half of {{ipc.client.rpc-timeout.ms}}. This logic dates back to 2009 
> in HDFS-278. At my company, we are interested in using short DFS client 
> timeouts (< 10 seconds). However, we're currently hesitant to do so because 
> that would flood the NameNode with lease renewals.
> I propose a setting {{dfs.client.lease.renewal.interval.ms}} that, if 
> nonzero, would be used as the lease renewal interval instead of 
> {{ipc.client.rpc-timeout.ms / 2}}. This would be useful for advanced users 
> that want to control their RPC timeout and lease renewals separately.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to