[
https://issues.apache.org/jira/browse/HDFS-17651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17912699#comment-17912699
]
ASF GitHub Bot commented on HDFS-17651:
---------------------------------------
KeeProMise commented on code in PR #7244:
URL: https://github.com/apache/hadoop/pull/7244#discussion_r1914064051
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/DFSRouterFaultInjector.java:
##########
@@ -0,0 +1,43 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hdfs.server.federation.router;
+
+import org.apache.hadoop.classification.VisibleForTesting;
+
+/**
+ * Used to inject certain faults for testing.
+ */
+public class DFSRouterFaultInjector {
+ @VisibleForTesting
+ private static DFSRouterFaultInjector instance =
+ new DFSRouterFaultInjector();
+
+ @VisibleForTesting
+ public static DFSRouterFaultInjector get() {
+ return instance;
+ }
+
+ public static void set(DFSRouterFaultInjector injector) {
+ instance = injector;
+ }
+
+ @VisibleForTesting
+ public boolean shouldSkipShutdownAsyncExecutors() {
+ return false;
+ }
+}
Review Comment:
Hi, @hfutatzhanghb
In my opinion, there is no major issue with this part. How about changing
async handler and responder to non-static properties of the rpc server? In that
case, wouldn't this class be unnecessary?
> [ARR] Async handler executor isolation.
> ---------------------------------------
>
> Key: HDFS-17651
> URL: https://issues.apache.org/jira/browse/HDFS-17651
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: farmmamba
> Assignee: farmmamba
> Priority: Major
> Labels: pull-request-available
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
