[ https://issues.apache.org/jira/browse/HDFS-17744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932549#comment-17932549 ]
ASF GitHub Bot commented on HDFS-17744: --------------------------------------- Hexiaoqiao commented on code in PR #7445: URL: https://github.com/apache/hadoop/pull/7445#discussion_r1980941636 ########## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/async/RouterAsyncClientProtocol.java: ########## @@ -1086,4 +1093,35 @@ public boolean isMultiDestDirectory(String src) { return asyncReturn(boolean.class); } + + @Override + public Path getEnclosingRoot(String src) throws IOException { + final Path[] mountPath = new Path[1]; Review Comment: Here give array which size is 1, what about `Path mountPath = null;`, any concerns here? > [ARR] getEnclosingRoot RPC adapts to async rpc > ---------------------------------------------- > > Key: HDFS-17744 > URL: https://issues.apache.org/jira/browse/HDFS-17744 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: rbf > Reporter: farmmamba > Assignee: farmmamba > Priority: Major > Labels: pull-request-available > > getEnclosingRoot RPC should also adapt to async rpc. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org