[
https://issues.apache.org/jira/browse/HDFS-17751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932636#comment-17932636
]
ASF GitHub Bot commented on HDFS-17751:
---------------------------------------
slfan1989 commented on PR #7470:
URL: https://github.com/apache/hadoop/pull/7470#issuecomment-2700984065
@hfutatzhanghb Thank you for your contribution! However, I don't think
adding unit tests for these packages is the best approach. If it's just a
change in configuration, using parameterized tests would be a more appropriate
choice, as it allows for maximum reuse of the existing test code. We can refer
to the following documentation for more details: [JUnit 5 Parameterized
Tests](https://junit.org/junit5/docs/current/user-guide/#writing-tests-parameterized-tests).
cc: @ayushtkn @steveloughran @Hexiaoqiao
> [ARR] Add unit tests using asynchronous router rpc for all in
> org.apache.hadoop.hdfs.server.federation.router
> -------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-17751
> URL: https://issues.apache.org/jira/browse/HDFS-17751
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: rbf, test
> Reporter: farmmamba
> Assignee: farmmamba
> Priority: Major
> Labels: pull-request-available
>
> This Jira aims to add unit tests using asynchronous router rpc for those
> existed unit tests which in org.apache.hadoop.hdfs.server.federation.router
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
