[
https://issues.apache.org/jira/browse/HDFS-17749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17936873#comment-17936873
]
ASF GitHub Bot commented on HDFS-17749:
---------------------------------------
KeeProMise commented on code in PR #7466:
URL: https://github.com/apache/hadoop/pull/7466#discussion_r2003669481
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/async/RouterAsyncClientProtocol.java:
##########
@@ -355,7 +355,6 @@ public boolean mkdirs(String src, FsPermission masked,
boolean createParent)
return rpcClient.invokeAll(locations, method);
}
- asyncComplete(false);
Review Comment:
Hi, @hfutatzhanghb I just took a look at this method, and I think it should
work fine without the modifications you suggested. First, set the
completeFuture in the thread pool variable to false. Next, if locations.size()
> 1, the completeFuture after execution will replace the thread variable. If
locations.size() <= 1, then since the initial value of completeFuture is set to
false, the subsequent asynchronous call code will be executed.
> [ARR] Fix wrong results due to the wrong usage of asyncComplete(null)
> ---------------------------------------------------------------------
>
> Key: HDFS-17749
> URL: https://issues.apache.org/jira/browse/HDFS-17749
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: rbf
> Reporter: farmmamba
> Assignee: farmmamba
> Priority: Major
> Labels: pull-request-available
>
> Fix below RPCs : getMountPointStatus、getListing、getFIleinfoAll、mkdirs
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
