[
https://issues.apache.org/jira/browse/HDFS-12431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18017777#comment-18017777
]
ASF GitHub Bot commented on HDFS-12431:
---------------------------------------
slfan1989 commented on code in PR #7922:
URL: https://github.com/apache/hadoop/pull/7922#discussion_r2317288321
##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestAvailableSpaceBPPBalanceLocal.java:
##########
@@ -137,8 +137,8 @@ public void testChooseLocalNode() {
.chooseTarget(FILE, 1, localNode,
new ArrayList<DatanodeStorageInfo>(), false, null,
BLOCK_SIZE,
TestBlockStoragePolicy.DEFAULT_STORAGE_POLICY, null);
- Assert.assertEquals(1, targets.length);
- Assert.assertEquals(localNode, targets[0].getDatanodeDescriptor());
+ Assertions.assertEquals(1, targets.length);
Review Comment:
It’s better for us to use static imports.
##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestBlockInfo.java:
##########
@@ -56,9 +56,9 @@ public void testIsDeleted() {
BlockInfo blockInfo = new BlockInfoContiguous((short) 3);
BlockCollection bc = Mockito.mock(BlockCollection.class);
blockInfo.setBlockCollectionId(1000);
- Assert.assertFalse(blockInfo.isDeleted());
+ Assertions.assertFalse(blockInfo.isDeleted());
Review Comment:
It’s better for us to use static imports.
> Upgrade JUnit from 4 to 5 in hadoop-hdfs hdfs
> -----------------------------------------------
>
> Key: HDFS-12431
> URL: https://issues.apache.org/jira/browse/HDFS-12431
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: test
> Reporter: Ajay Kumar
> Assignee: Hualong Zhang
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.5.0
>
>
> Upgrade JUnit from 4 to 5 in hadoop-hdfs hdfs (i.e org.apache.hadoop.hdfs)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
