[
https://issues.apache.org/jira/browse/HDFS-17828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18022461#comment-18022461
]
ASF GitHub Bot commented on HDFS-17828:
---------------------------------------
steveloughran commented on code in PR #7955:
URL: https://github.com/apache/hadoop/pull/7955#discussion_r2376168925
##########
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/TestGenericTestUtils.java:
##########
@@ -35,31 +37,39 @@ public class TestGenericTestUtils extends GenericTestUtils {
@Test
public void testAssertExceptionContainsNullEx() throws Throwable {
+ boolean assertTriggered = false;
try {
assertExceptionContains("", null);
} catch (AssertionError e) {
+ assertTriggered = true;
if (!e.toString().contains(E_NULL_THROWABLE)) {
throw e;
}
}
+ assertTrue(assertTriggered);
}
@Test
public void testAssertExceptionContainsNullString() throws Throwable {
+ boolean assertTriggered = false;
try {
assertExceptionContains("", new BrokenException());
} catch (AssertionError e) {
+ assertTriggered = true;
if (!e.toString().contains(E_NULL_THROWABLE_STRING)) {
throw e;
}
}
+ assertTrue(assertTriggered);
}
@Test
public void testAssertExceptionContainsWrongText() throws Throwable {
+ boolean assertTriggered = false;
try {
assertExceptionContains("Expected", new Exception("(actual)"));
} catch (AssertionError e) {
+ assertTriggered = true;
String s = e.toString();
if (!s.contains(E_UNEXPECTED_EXCEPTION)
Review Comment:
again, use intercept, but here
```
AssertionError e = intercept(AssertionError.class, "", () ->
assertExceptionContains("Expected", new Exception("(actual)")));
// checks from L32 onwards
String s = e.toString();
if (!s.contains(E_UNEXPECTED_EXCEPTION) ...
##########
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/TestGenericTestUtils.java:
##########
@@ -35,31 +37,39 @@ public class TestGenericTestUtils extends GenericTestUtils {
@Test
public void testAssertExceptionContainsNullEx() throws Throwable {
+ boolean assertTriggered = false;
Review Comment:
use LambdaTestUtils.intercept here.
```
intercept(AssertionError.class, E_NULL_THROWABLE, () ->
assertExceptionContains("", null));
```
same below.
> SocketTimeoutException not recognized in TestWebHdfsTimeouts with Java 24
> -------------------------------------------------------------------------
>
> Key: HDFS-17828
> URL: https://issues.apache.org/jira/browse/HDFS-17828
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: hdfs, test
> Affects Versions: 3.5.0
> Reporter: Istvan Toth
> Assignee: Istvan Toth
> Priority: Major
> Labels: java24, pull-request-available
>
> Java 24 capitalizes "Connect" in th Exception message, which the test does
> not recognize.
> {noformat}
> [ERROR]
> org.apache.hadoop.hdfs.web.TestWebHdfsTimeouts.testAuthUrlConnectTimeout(TimeoutSource)[2]
> -- Time elapsed: 0.313 s <<< FAILURE!
> java.lang.AssertionError:
> Expected to find 'localhost:33473: connect timed out' but got unexpected
> exception: java.net.SocketTimeoutException: localhost:33473: Connect timed out
> at
> java.base/sun.nio.ch.NioSocketImpl.timedFinishConnect(NioSocketImpl.java:537)
> at java.base/sun.nio.ch.NioSocketImpl.connect(NioSocketImpl.java:583)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
