[
https://issues.apache.org/jira/browse/HDFS-16543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18037932#comment-18037932
]
ASF GitHub Bot commented on HDFS-16543:
---------------------------------------
github-actions[bot] commented on PR #4178:
URL: https://github.com/apache/hadoop/pull/4178#issuecomment-3524494602
We're closing this stale PR because it has been open for 100 days with no
activity. This isn't a judgement on the merit of the PR in any way. It's just a
way of keeping the PR queue manageable.
If you feel like this was a mistake, or you would like to continue working
on it, please feel free to re-open it and ask for a committer to remove the
stale tag and review again.
Thanks all for your contribution.
> Keep default value of dfs.datanode.directoryscan.throttle.limit.ms.per.sec
> consistent
> -------------------------------------------------------------------------------------
>
> Key: HDFS-16543
> URL: https://issues.apache.org/jira/browse/HDFS-16543
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: configuration, datanode
> Affects Versions: 3.3.2
> Reporter: daimin
> Assignee: daimin
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 2h
> Remaining Estimate: 0h
>
> "WARN datanode.DirectoryScanner (DirectoryScanner.java:<init>(300)) -
> dfs.datanode.directoryscan.throttle.limit.ms.per.sec set to value above 1000
> ms/sec. Assuming default value of -1"
> A warning log like above will be printed when datanode is starting. The
> reason of that is the default value of
> dfs.datanode.directoryscan.throttle.limit.ms.per.sec is 1000 in
> hdfs-site.xml, and is -1 in
> DFS_DATANODE_DIRECTORYSCAN_THROTTLE_LIMIT_MS_PER_SEC_DEFAULT. We should try
> to keep it consistent, and value -1 looks is better to 1000.
> The code segment that print the warning log:
> if (throttle >= TimeUnit.SECONDS.toMillis(1)) {
> LOG.warn(
> "{} set to value above 1000 ms/sec. Assuming default value of {}",
> DFSConfigKeys.DFS_DATANODE_DIRECTORYSCAN_THROTTLE_LIMIT_MS_PER_SEC_KEY,
>
> DFSConfigKeys.DFS_DATANODE_DIRECTORYSCAN_THROTTLE_LIMIT_MS_PER_SEC_DEFAULT);
> throttle =
>
> DFSConfigKeys.DFS_DATANODE_DIRECTORYSCAN_THROTTLE_LIMIT_MS_PER_SEC_DEFAULT;
> }
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
