[
https://issues.apache.org/jira/browse/HDFS-16439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18039024#comment-18039024
]
ASF GitHub Bot commented on HDFS-16439:
---------------------------------------
github-actions[bot] commented on PR #3937:
URL: https://github.com/apache/hadoop/pull/3937#issuecomment-3544466430
We're closing this stale PR because it has been open for 100 days with no
activity. This isn't a judgement on the merit of the PR in any way. It's just a
way of keeping the PR queue manageable.
If you feel like this was a mistake, or you would like to continue working
on it, please feel free to re-open it and ask for a committer to remove the
stale tag and review again.
Thanks all for your contribution.
> Makes calculating maxNodesPerRack simpler
> -----------------------------------------
>
> Key: HDFS-16439
> URL: https://issues.apache.org/jira/browse/HDFS-16439
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
> Affects Versions: 3.4.0
> Reporter: JiangHua Zhu
> Assignee: JiangHua Zhu
> Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> When creating a new file, it is usually necessary to communicate with the
> namenode first to obtain the location of some DataNodes as the target
> location of Blockd. At this time, when
> BlockPlacementPolicyDefault#getMaxNodesPerRack() is executed, if the number
> of replicas is very large, once it exceeds the number of all nodes in the
> cluster. The following piece of code will be executed:
> int clusterSize = clusterMap.getNumOfLeaves();
> int totalNumOfReplicas = numOfChosen + numOfReplicas;
> if (totalNumOfReplicas > clusterSize) {
> numOfReplicas -= (totalNumOfReplicas-clusterSize);
> totalNumOfReplicas = clusterSize;
> }
> Here, the calculation for numOfReplicas gets a little more complicated. It
> can be simplified like:
> numOfReplicas = clusterSize - numOfChosen
> It would be more helpful to understand it this way, while also freeing up a
> little cpu (though not a lot).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
