[
https://issues.apache.org/jira/browse/HDFS-16179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18040738#comment-18040738
]
ASF GitHub Bot commented on HDFS-16179:
---------------------------------------
github-actions[bot] commented on PR #3313:
URL: https://github.com/apache/hadoop/pull/3313#issuecomment-3578184560
We're closing this stale PR because it has been open for 100 days with no
activity. This isn't a judgement on the merit of the PR in any way. It's just a
way of keeping the PR queue manageable.
If you feel like this was a mistake, or you would like to continue working
on it, please feel free to re-open it and ask for a committer to remove the
stale tag and review again.
Thanks all for your contribution.
> Update loglevel for BlockManager#chooseExcessRedundancyStriped to avoid too
> much logs
> -------------------------------------------------------------------------------------
>
> Key: HDFS-16179
> URL: https://issues.apache.org/jira/browse/HDFS-16179
> Project: Hadoop HDFS
> Issue Type: Improvement
> Affects Versions: 3.1.0
> Reporter: Tao Li
> Assignee: Tao Li
> Priority: Minor
> Labels: pull-request-available
> Attachments: log-count.jpg, logs.jpg
>
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> {code:java}
> private void chooseExcessRedundancyStriped(BlockCollection bc,
> final Collection<DatanodeStorageInfo> nonExcess,
> BlockInfo storedBlock,
> DatanodeDescriptor delNodeHint) {
> ...
> // cardinality of found indicates the expected number of internal blocks
> final int numOfTarget = found.cardinality();
> final BlockStoragePolicy storagePolicy = storagePolicySuite.getPolicy(
> bc.getStoragePolicyID());
> final List<StorageType> excessTypes = storagePolicy.chooseExcess(
> (short) numOfTarget, DatanodeStorageInfo.toStorageTypes(nonExcess));
> if (excessTypes.isEmpty()) {
> LOG.warn("excess types chosen for block {} among storages {} is empty",
> storedBlock, nonExcess);
> return;
> }
> ...
> }
> {code}
>
> IMO, here is just detecting excess StorageType and setting the log level to
> debug has no effect.
>
> We have a cluster that uses the EC policy to store data. The current log
> level is WARN here, and in about 50 minutes, 286,093 logs are printed, which
> can cause other important logs to drown out.
>
> !logs.jpg|width=1167,height=62!
>
> !log-count.jpg|width=760,height=30!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
