[ 
https://issues.apache.org/jira/browse/HDFS-3592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18071846#comment-18071846
 ] 

ASF GitHub Bot commented on HDFS-3592:
--------------------------------------

hfutatzhanghb commented on PR #8411:
URL: https://github.com/apache/hadoop/pull/8411#issuecomment-4203652052

   @cmccabe @Hexiaoqiao @KeeProMise Hi, could you please help review this pr 
when you have free time?




> libhdfs should use ClientProtocol::rename2
> ------------------------------------------
>
>                 Key: HDFS-3592
>                 URL: https://issues.apache.org/jira/browse/HDFS-3592
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 2.0.0-alpha, 3.0.0-alpha1
>            Reporter: Colin McCabe
>            Assignee: Colin McCabe
>            Priority: Minor
>              Labels: BB2015-05-TBR, pull-request-available
>         Attachments: HDFS-3592.001.patch
>
>
> It would be nice if libhdfs exposed rename2.  This version of rename is much 
> more verbose about any errors that occur-- it throws AccessControlException, 
> FileAlreadyExists, FileNotFoundException, ParentNotDirectoryException, etc.
> The original rename returns false in many distinct cases, making it ambiguous 
> exactly what the problem was.
> For something like fuse_dfs, it is very important to return the correct errno 
> code when an error has occurred.  rename2 would allow us to do that.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to