[
https://issues.apache.org/jira/browse/HDFS-2922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212948#comment-13212948
]
Aaron T. Myers commented on HDFS-2922:
--------------------------------------
Patch largely looks good, Eli. A few comments:
# I think you should remove the change to the logging in the event of
failovers. I was under the impression that Todd had addressed your concerns
with the addition of the "worthLogging" boolean which causes a message to be
logged only in the event of a client failover after a previous successful RPC
call.
# Rather than just add a comment saying we're not checking the op category in
the case of administrative commands, let's add another op category explicitly
for administrative commands that could reasonably be run on either NN, and
adjust StandbyState#checkOperation accordingly.
# I think the operation category for getTransactionID should be CHECKPOINT,
since that's what it's used for.
# There are 2 lines changed in comments that have no discernible change. Errant
whitespace changes?
> HA: close out operation categories
> ----------------------------------
>
> Key: HDFS-2922
> URL: https://issues.apache.org/jira/browse/HDFS-2922
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha
> Affects Versions: HA branch (HDFS-1623)
> Reporter: Eli Collins
> Assignee: Eli Collins
> Attachments: hdfs-2922.txt, hdfs-2922.txt, hdfs-2922.txt
>
>
> We need to close out the NN operations categories.
> The following operations should be left as is, ie not failover, as it's
> reasonable to call these on a standby, and we just need to update the TODO
> with a comment:
> - {{setSafeMode}} (Might want to force the standby out of safemode)
> - {{restoreFailedStorage}} (Might want to tell the standby to restore the
> shared edits dir)
> - {{saveNamespace}}, {{metaSave}} (Could imagine calling these on a standby
> eg in a recovery scenario)
> - {{refreshNodes}} (Decommissioning needs to refresh the standby)
> The following operations should be checked for READ, as neither should need
> to be called on standby, will failover unless stale reads are enabled:
> - {{getTransactionID}}, {{getEditLogManifest}} (we don't checkoint the
> standby)
> The following operations should be checked for WRITE, as they should not be
> called on a standby, ie should always failover:
> - {{finalizeUpgrade}}, {{distributedUpgradeProgress}} (should not be able to
> upgrade the standby)
> - {{setBalancerBandwidth}} (balancer should failover)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
