[ 
https://issues.apache.org/jira/browse/HDFS-17685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18080653#comment-18080653
 ] 

ASF GitHub Bot commented on HDFS-17685:
---------------------------------------

charlesconnell opened a new pull request, #7215:
URL: https://github.com/apache/hadoop/pull/7215

   <!--
     Thanks for sending a pull request!
       1. If this is your first time, please read our contributor guidelines: 
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
       2. Make sure your PR title starts with JIRA issue id, e.g., 
'HADOOP-17799. Your PR title ...'.
   -->
   
   ### Description of PR
   
   Currently, DFSClients send lease renewals to the NameNode at an interval 
equal to half of `ipc.client.rpc-timeout.ms`. This logic dates back to 2009 in 
[HDFS-278](https://issues.apache.org/jira/browse/HDFS-278). At my company, we 
are interested in using short DFS client timeouts (< 10 seconds). However, 
we're currently hesitant to do so because that would flood the NameNode with 
lease renewals.
   
   I propose a setting `dfs.client.lease.renewal.interval.ms` that, if nonzero, 
would be used as the lease renewal interval instead of 
`ipc.client.rpc-timeout.ms / 2`. This would be useful for advanced users that 
want to control their RPC timeout and lease renewals separately.
   
   ### How was this patch tested?
   
   Unit tests are included in this PR for the new logic. I have also tested the 
new feature in my company's HBase infrastructure.
   
   
   ### For code changes:
   
   - [x] Does the title or this PR starts with the corresponding JIRA issue id 
(e.g. 'HADOOP-17799. Your PR title ...')?
   - [ ] ~Object storage: have the integration tests been executed and the 
endpoint declared according to the connector-specific documentation?~ not 
applicable
   - [ ] ~If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?~ not applicable
   - [ ] ~If applicable, have you updated the `LICENSE`, `LICENSE-binary`, 
`NOTICE-binary` files?~ not applicable
   
   




> Option to explicitly choose DFS client lease renewal interval
> -------------------------------------------------------------
>
>                 Key: HDFS-17685
>                 URL: https://issues.apache.org/jira/browse/HDFS-17685
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: dfsclient
>            Reporter: Charles Connell
>            Priority: Minor
>              Labels: pull-request-available
>
> Currently, DFSClients send lease renewals to the NameNode at an interval 
> equal to half of {{ipc.client.rpc-timeout.ms}}. This logic dates back to 2009 
> in HDFS-278. At my company, we are interested in using short DFS client 
> timeouts (< 10 seconds). However, we're currently hesitant to do so because 
> that would flood the NameNode with lease renewals.
> I propose a setting {{dfs.client.lease.renewal.interval.ms}} that, if 
> nonzero, would be used as the lease renewal interval instead of 
> {{ipc.client.rpc-timeout.ms / 2}}. This would be useful for advanced users 
> that want to control their RPC timeout and lease renewals separately.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to