[
https://issues.apache.org/jira/browse/HDFS-17909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18082195#comment-18082195
]
ASF GitHub Bot commented on HDFS-17909:
---------------------------------------
ZanderXu commented on code in PR #8448:
URL: https://github.com/apache/hadoop/pull/8448#discussion_r3270966747
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/async/RouterAsyncRpcClient.java:
##########
@@ -57,6 +57,8 @@
import java.util.Map;
import java.util.concurrent.Callable;
import java.util.concurrent.CompletableFuture;
+import java.util.concurrent.RejectedExecutionException;
+import java.util.concurrent.ThreadPoolExecutor;
Review Comment:
Unused.
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/async/RouterAsyncRpcClient.java:
##########
@@ -173,13 +175,15 @@ public Object invokeMethod(
+ router.getRouterId());
}
String nsid = namenodes.get(0).getNameserviceId();
+
Review Comment:
unnecessary
> [ARR] AsyncRouterHandlerExecutors should use bounded queue
> ----------------------------------------------------------
>
> Key: HDFS-17909
> URL: https://issues.apache.org/jira/browse/HDFS-17909
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: rbf
> Reporter: Felix N
> Assignee: Felix N
> Priority: Major
> Labels: pull-request-available
>
> AsyncRouterHandlerExecutors should use bounded queues to prevent queues from
> growing without a limit.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
