[
https://issues.apache.org/jira/browse/HDFS-17927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18083688#comment-18083688
]
ASF GitHub Bot commented on HDFS-17927:
---------------------------------------
smengcl opened a new pull request, #8517:
URL: https://github.com/apache/hadoop/pull/8517
### Description of PR
`TestDiskError.testShutdown()` currently drives DataNode shutdown by
repeatedly creating files until `dn.isDatanodeUp()` becomes false. If shutdown
does not happen promptly, the test can loop for a long time and generate
excessive logs.
This change replaces the file-create loop with deterministic failure
injection for both DataNode data dirs, then explicitly runs
`dn.checkDiskError()` and waits boundedly for the DataNode to exit.
### How was this patch tested?
- The test `TestDiskError.testShutdown` itself.
### For code changes:
- [x] Does the title or this PR starts with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: have the integration tests been executed and the
endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`,
`NOTICE-binary` files?
### AI Tooling
If an AI tool was used:
- [ ] The PR includes the phrase "Contains content generated by <tool>"
where <tool> is the name of the AI tool used.
- [ ] My use of AI contributions follows the ASF legal policy
https://www.apache.org/legal/generative-tooling.html
> Make TestDiskError.testShutdown use deterministic volume failure injection
> --------------------------------------------------------------------------
>
> Key: HDFS-17927
> URL: https://issues.apache.org/jira/browse/HDFS-17927
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: test
> Reporter: Siyao Meng
> Assignee: Siyao Meng
> Priority: Major
>
> `TestDiskError.testShutdown()` currently drives DataNode shutdown by
> repeatedly creating files until `dn.isDatanodeUp()` becomes false. If
> shutdown does not happen promptly, the test can loop for a long time and
> generate excessive logs.
> Replaces file-create loop with deterministic failure injection for both
> DataNode data dirs, then explicitly runs `dn.checkDiskError()` and waits for
> the DataNode to exit.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
