[
https://issues.apache.org/jira/browse/HDFS-17561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18088182#comment-18088182
]
ASF GitHub Bot commented on HDFS-17561:
---------------------------------------
ZanderXu commented on code in PR #8541:
URL: https://github.com/apache/hadoop/pull/8541#discussion_r3394081435
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeManager.java:
##########
@@ -90,6 +90,8 @@ public class DatanodeManager {
private volatile long heartbeatIntervalSeconds;
private volatile int heartbeatRecheckInterval;
+ /** Used by {@link HeartbeatManager}. */
+ private volatile long heartbeatRecheckIntervalForMonitor;
Review Comment:
How about moving it to `HeartbeatManager`?
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeManager.java:
##########
@@ -2213,6 +2216,19 @@ private void setHeartbeatInterval(long intervalSeconds,
this.heartbeatExpireInterval = 2L * recheckInterval + 10 * 1000
* intervalSeconds;
this.blockInvalidateLimit = getBlockInvalidateLimit(blockInvalidateLimit);
+ refreshHeartbeatRecheckIntervalForMonitor();
+ }
+
+ @VisibleForTesting
+ public void refreshHeartbeatRecheckIntervalForMonitor() {
Review Comment:
Move this method to `HeartbeatManager` and just change it if
`heartbeatRecheckInterval` is changed.
> Make HeartbeatManager.Monitor use up-to-date heartbeatRecheckInterval
> ---------------------------------------------------------------------
>
> Key: HDFS-17561
> URL: https://issues.apache.org/jira/browse/HDFS-17561
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Felix N
> Assignee: Felix N
> Priority: Minor
> Labels: pull-request-available
>
> DatanodeManager can changes heartbeatRecheckInterval via reconf API but
> HeartbeatManager's copy of heartbeatRecheckInterval is fixed at
> initialization and won't update when DatanodeManager updates with a new
> config.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
