[
https://issues.apache.org/jira/browse/HDFS-17946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18095276#comment-18095276
]
ASF GitHub Bot commented on HDFS-17946:
---------------------------------------
hadoop-yetus commented on PR #8593:
URL: https://github.com/apache/hadoop/pull/8593#issuecomment-4935230593
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 54s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 1 new or modified test files. |
|||| _ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 46m 58s | | trunk passed |
| +1 :green_heart: | compile | 18m 25s | | trunk passed with JDK
Ubuntu-21.0.11+10-1-24.04.2-Ubuntu |
| +1 :green_heart: | compile | 18m 13s | | trunk passed with JDK
Ubuntu-17.0.19+10-1-24.04.2-Ubuntu |
| +1 :green_heart: | checkstyle | 1m 30s | | trunk passed |
| +1 :green_heart: | mvnsite | 2m 0s | | trunk passed |
| +1 :green_heart: | javadoc | 1m 24s | | trunk passed with JDK
Ubuntu-21.0.11+10-1-24.04.2-Ubuntu |
| +1 :green_heart: | javadoc | 1m 22s | | trunk passed with JDK
Ubuntu-17.0.19+10-1-24.04.2-Ubuntu |
| +1 :green_heart: | spotbugs | 3m 13s | | trunk passed |
| +1 :green_heart: | shadedclient | 36m 32s | | branch has no errors
when building and testing our client artifacts. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 1m 15s | | the patch passed |
| +1 :green_heart: | compile | 16m 39s | | the patch passed with JDK
Ubuntu-21.0.11+10-1-24.04.2-Ubuntu |
| +1 :green_heart: | javac | 16m 39s | | the patch passed |
| +1 :green_heart: | compile | 18m 10s | | the patch passed with JDK
Ubuntu-17.0.19+10-1-24.04.2-Ubuntu |
| +1 :green_heart: | javac | 18m 10s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| -0 :warning: | checkstyle | 1m 27s |
[/results-checkstyle-hadoop-common-project_hadoop-common.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8593/2/artifact/out/results-checkstyle-hadoop-common-project_hadoop-common.txt)
| hadoop-common-project/hadoop-common: The patch generated 4 new + 215
unchanged - 0 fixed = 219 total (was 215) |
| +1 :green_heart: | mvnsite | 1m 53s | | the patch passed |
| +1 :green_heart: | javadoc | 1m 20s | | the patch passed with JDK
Ubuntu-21.0.11+10-1-24.04.2-Ubuntu |
| +1 :green_heart: | javadoc | 1m 22s | | the patch passed with JDK
Ubuntu-17.0.19+10-1-24.04.2-Ubuntu |
| +1 :green_heart: | spotbugs | 3m 23s | | the patch passed |
| +1 :green_heart: | shadedclient | 37m 7s | | patch has no errors
when building and testing our client artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 23m 33s | | hadoop-common in the patch
passed. |
| +1 :green_heart: | asflicense | 1m 12s | | The patch does not
generate ASF License warnings. |
| | | 239m 13s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.55 ServerAPI=1.55 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8593/2/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/8593 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
| uname | Linux 463aa0fa48f6 5.15.0-181-generic #191-Ubuntu SMP Fri May 22
19:09:02 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 65c8ff44990af8fbc28cd9a48231fc325456385c |
| Default Java | Ubuntu-17.0.19+10-1-24.04.2-Ubuntu |
| Multi-JDK versions |
/usr/lib/jvm/java-21-openjdk-amd64:Ubuntu-21.0.11+10-1-24.04.2-Ubuntu
/usr/lib/jvm/java-17-openjdk-amd64:Ubuntu-17.0.19+10-1-24.04.2-Ubuntu |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8593/2/testReport/ |
| Max. process+thread count | 1470 (vs. ulimit of 10000) |
| modules | C: hadoop-common-project/hadoop-common U:
hadoop-common-project/hadoop-common |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8593/2/console |
| versions | git=2.43.0 maven=3.9.15 spotbugs=4.9.7 |
| Powered by | Apache Yetus 0.14.1 https://yetus.apache.org |
This message was automatically generated.
> Several HDFS client integer configs report raw NumberFormatException for
> out-of-range values
> --------------------------------------------------------------------------------------------
>
> Key: HDFS-17946
> URL: https://issues.apache.org/jira/browse/HDFS-17946
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: hdfs-client
> Reporter: jiang he
> Priority: Trivial
> Labels: pull-request-available
>
> Several HDFS client integer configuration keys fail with a raw
> NumberFormatException when set to an out-of-range negative value.
> Instead of exposing a raw NumberFormatException, HDFS should report a clear
> configuration validation error that identifies the invalid key and expected
> range.
> Examples
> Example 1
> <property>
> <name>dfs.client.block.write.retries</name>
> <value>-4294967296</value>
> </property>
> Observed:
> Failed to initialize filesystem hdfs://127.0.0.1:9000:
> java.lang.NumberFormatException: For input string: "-4294967296"
> Example 2
> <property>
> <name>dfs.client.pipeline.recovery.max-retries</name>
> <value>-4294967296</value>
> </property>
> Observed:
> Failed to initialize filesystem hdfs://127.0.0.1:9000:
> java.lang.NumberFormatException: For input string: "-4294967296"
> Example 3
> <property>
> <name>dfs.client.retry.max.attempts</name>
> <value>-4294967296</value>
> </property>
> Observed:
> Failed to initialize filesystem hdfs://127.0.0.1:9000:
> java.lang.NumberFormatException: For input string: "-4294967296"
> Example 4
> <property>
> <name>dfs.client.congestion.backoff.mean.time</name>
> <value>-4294967296</value>
> </property>
> Observed:
> java.lang.NumberFormatException: For input string: "-4294967296"
> Expected
> HDFS should report clear configuration validation errors, for example:
> Invalid value for dfs.client.block.write.retries: -4294967296.
> The value must be a valid integer within range ...
> rather than a raw NumberFormatException.
> Control test
> The following normal values pass successfully:
> <property>
> <name>dfs.client.block.write.retries</name>
> <value>3</value>
> </property>
> <property>
> <name>dfs.client.pipeline.recovery.max-retries</name>
> <value>5</value>
> </property>
> <property>
> <name>dfs.client.retry.max.attempts</name>
> <value>10</value>
> </property>
> <property>
> <name>dfs.client.congestion.backoff.mean.time</name>
> <value>5000</value>
> </property>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
