[ https://issues.apache.org/jira/browse/HDFS-2990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13215233#comment-13215233 ]
Colin Patrick McCabe commented on HDFS-2990: -------------------------------------------- Hi Nicholas, I will try the refactoring you suggested once I get a chance. It sounds like a good idea if it's possible! C. > Move OfflineImageViewer, OfflineEditsViewer into the same package as the > NameNode > --------------------------------------------------------------------------------- > > Key: HDFS-2990 > URL: https://issues.apache.org/jira/browse/HDFS-2990 > Project: Hadoop HDFS > Issue Type: Bug > Reporter: Colin Patrick McCabe > Assignee: Colin Patrick McCabe > Attachments: HDFS-2990.patch > > > Since OfflineImageviewer and OfflineEditsVeiwer are in different namespaces > than the NameNode, we can't ruuse a lot of the code from the NameNode without > making things public that we probably don't want to make public. Let's move > them into the NameNode namespace to avoid this problem. These tools will > always be tightly tied to the NameNode anyway (they are parsing the same > on-disk structures, after all), so that is where they belong. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira