[ 
https://issues.apache.org/jira/browse/HDFS-3050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235989#comment-13235989
 ] 

Hadoop QA commented on HDFS-3050:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12519498/HDFS-3050.009.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    -1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2072//console

This message is automatically generated.
                
> refactor OEV to share more code with the NameNode
> -------------------------------------------------
>
>                 Key: HDFS-3050
>                 URL: https://issues.apache.org/jira/browse/HDFS-3050
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>            Priority: Minor
>         Attachments: HDFS-3050.006.patch, HDFS-3050.007.patch, 
> HDFS-3050.008.patch, HDFS-3050.009.patch
>
>
> Current, OEV (the offline edits viewer) re-implements all of the opcode 
> parsing logic found in the NameNode.  This duplicated code creates a 
> maintenance burden for us.
> OEV should be refactored to simply use the normal EditLog parsing code, 
> rather than rolling its own.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to