[ 
https://issues.apache.org/jira/browse/HDFS-3131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aaron T. Myers updated HDFS-3131:
---------------------------------

          Resolution: Fixed
       Fix Version/s: 1.1.0
                      0.24.0
    Target Version/s: 0.24.0, 1.1.0  (was: 1.1.0, 0.24.0)
        Release Note:   (was: added test case to make sure that restore failure 
doesn't stop checkpoint process)
        Hadoop Flags: Reviewed
              Status: Resolved  (was: Patch Available)

I've just committed this to trunk and branch-1.

Thanks a lot for the contribution, Brandon.
                
> Improve TestStorageRestore
> --------------------------
>
>                 Key: HDFS-3131
>                 URL: https://issues.apache.org/jira/browse/HDFS-3131
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 0.24.0, 1.1.0
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Brandon Li
>            Priority: Minor
>              Labels: newbie
>             Fix For: 0.24.0, 1.1.0
>
>         Attachments: HDFS-3131.branch-1.patch, HDFS-3131.patch, 
> HDFS-3131.patch
>
>
> Aaron has the following comments on TestStorageRestore in HDFS-3127.
> # removeStorageAccess, restoreAccess, and numStorageDirs can all be made 
> private
> # numStorageDirs can be made static
> # Rather than do set(Readable/Executable/Writable), use FileUtil.chmod(...).
> # Please put the contents of the test in a try/finally, with the calls to 
> shutdown the cluster and the 2NN in the finally block.
> # Some lines are over 80 chars.
> # No need for the numDatanodes variable - it's only used in one place.
> # Instead of "xwr" use "rwx", which I think is a more common way of 
> describing permissions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to