[ 
https://issues.apache.org/jira/browse/HDFS-3143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13240598#comment-13240598
 ] 

Tsz Wo (Nicholas), SZE commented on HDFS-3143:
----------------------------------------------

Hi Aaron and Todd,

The changes probably is not intentional but it is a good change since the class 
name should not be in the message.  Exception messages are not APIs and so it 
can be changed anytime.  Also, test should avoid depending on the message 
format.  However, CLI error messages are a kind of public APIs.  They should 
not be changed unless there are bugs.

Since the new CLI re-write is not out yet and it is better not to have the 
class name in the message, I think we should keep the current message format 
and fix the tests.  What do you think?
                
> TestGetBlocks.testGetBlocks is failing
> --------------------------------------
>
>                 Key: HDFS-3143
>                 URL: https://issues.apache.org/jira/browse/HDFS-3143
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: test
>            Reporter: Eli Collins
>            Assignee: Arpit Gupta
>         Attachments: HDFS-3143.patch
>
>
> TestGetBlocks.testGetBlocks is failing in the latest trunk/23 builds. Last 
> good build was Mar 23rd.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to