[ https://issues.apache.org/jira/browse/HDFS-3190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245778#comment-13245778 ]
Todd Lipcon commented on HDFS-3190: ----------------------------------- thanks Bikas. Quick question for reviewers: when I moved this code, I noticed the {{canRead()}} check. Currently if the file exists but can't be read, it returns the default value. I thought this was a little suspicious. Anyone adverse to removing that check, so that we throw an exception if it exists but we can't read it? Or better to keep this as a straight refactor and file a follow-up to think about that? > Simple refactors in existing NN code to assist QuorumJournalManager extension > ----------------------------------------------------------------------------- > > Key: HDFS-3190 > URL: https://issues.apache.org/jira/browse/HDFS-3190 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: name-node > Affects Versions: 2.0.0 > Reporter: Todd Lipcon > Assignee: Todd Lipcon > Priority: Minor > Attachments: hdfs-3190.txt > > > This JIRA is for some simple refactors in the NN: > - refactor the code which writes the seen_txid file in NNStorage into a new > "LongContainingFile" utility class. This is useful for the JournalNode to > atomically/durably record its last promised epoch > - refactor the interface from FileJournalManager back to StorageDirectory to > use a StorageErrorReport interface. This allows FileJournalManager to be used > in isolation of a full StorageDirectory. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira