[ 
https://issues.apache.org/jira/browse/HDFS-3084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246087#comment-13246087
 ] 

Aaron T. Myers commented on HDFS-3084:
--------------------------------------

+1, the patch looks good to me. Good stuff, Todd.
                
> FenceMethod.tryFence() and ShellCommandFencer should pass namenodeId as well 
> as host:port
> -----------------------------------------------------------------------------------------
>
>                 Key: HDFS-3084
>                 URL: https://issues.apache.org/jira/browse/HDFS-3084
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: ha
>    Affects Versions: 0.24.0, 0.23.3
>            Reporter: Philip Zeyliger
>            Assignee: Todd Lipcon
>         Attachments: hdfs-3084.txt
>
>
> The FenceMethod interface passes along the host:port of the NN that needs to 
> be fenced.  That's great for the common case.  However, it's likely necessary 
> to have extra configuration parameters for fencing, and these are typically 
> keyed off the nameserviceId.namenodeId (if, for nothing else, consistency 
> with all the other parameters that are keyed off of namespaceId.namenodeId).  
> Obviously this can be backed out from the host:port, but it's inconvenient, 
> and requires iterating through all the configs.
> The shell interface exhibits the same issue: host:port is great for most 
> fencers, but if you need extra configs (like the host:port of the power 
> supply unit), those are harder to pipe through without the namenodeId.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to