[
https://issues.apache.org/jira/browse/HDFS-3050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246675#comment-13246675
]
Hadoop QA commented on HDFS-3050:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12521352/HDFS-3050.019.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 9 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated 2 warning messages.
-1 javac. The applied patch generated 20 javac compiler warnings (more
than the trunk's current 14 warnings).
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hdfs.server.namenode.TestValidateConfigurationSettings
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/2184//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2184//console
This message is automatically generated.
> rework OEV to share more code with the NameNode
> -----------------------------------------------
>
> Key: HDFS-3050
> URL: https://issues.apache.org/jira/browse/HDFS-3050
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: name-node
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HDFS-3050.006.patch, HDFS-3050.007.patch,
> HDFS-3050.008.patch, HDFS-3050.009.patch, HDFS-3050.010.patch,
> HDFS-3050.011.patch, HDFS-3050.012.patch, HDFS-3050.014.patch,
> HDFS-3050.015.patch, HDFS-3050.016.patch, HDFS-3050.017.patch,
> HDFS-3050.018.patch, HDFS-3050.019.patch
>
>
> Current, OEV (the offline edits viewer) re-implements all of the opcode
> parsing logic found in the NameNode. This duplicated code creates a
> maintenance burden for us.
> OEV should be refactored to simply use the normal EditLog parsing code,
> rather than rolling its own. By using the existing FSEditLogLoader code to
> load edits in OEV, we can avoid having to update two places when the format
> changes.
> We should not put opcode checksums into the XML, because they are a
> serialization detail, not related to what the data is what we're storing.
> This will also make it possible to modify the XML file and translate this
> modified file back to a binary edits log file.
> Finally, this changes introduces --fix-txids. When OEV is passed this flag,
> it will close gaps in the transaction log by modifying the sequence numbers.
> This is useful if you want to modify the edit log XML (say, by removing a
> transaction), and transform the modified XML back into a valid binary edit
> log file.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
