[ https://issues.apache.org/jira/browse/HDFS-3202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247400#comment-13247400 ]
Suresh Srinivas commented on HDFS-3202: --------------------------------------- bq. Suresh, if you feel strongly about removing one of the NamespaceInfo constructor variants, I'd be happy to do that in a follow-up JIRA. Just wanted to avoid the many variants of constructors and methods. Our code is replete with this :-) But no issues with the patch though. > NamespaceInfo PB translation drops build version > ------------------------------------------------ > > Key: HDFS-3202 > URL: https://issues.apache.org/jira/browse/HDFS-3202 > Project: Hadoop HDFS > Issue Type: Bug > Components: data-node > Affects Versions: 2.0.0 > Reporter: Aaron T. Myers > Assignee: Aaron T. Myers > Fix For: 2.0.0 > > Attachments: HDFS-3202.patch > > > The PBHelper#convert(NamespaceInfoProto) function doesn't pass the build > version from the NamespaceInfoProto to the created NamespaceInfo object. > Instead, the NamespaceInfo constructor gets the build version using the > static function Storage#getBuildVersion. DNs also use this static function to > determine their own build version. This means that the check the DN does to > compare its own build version to that of the NN always passes, regardless of > what build version exists on the NN. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira