[ 
https://issues.apache.org/jira/browse/HDFS-2983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247947#comment-13247947
 ] 

Aaron T. Myers commented on HDFS-2983:
--------------------------------------

bq. It is a shame but this is not what I mean. During a upgrade, the upgrade 
version is known and unique. Only that version is put in the conf but not a 
list of acceptable versions. 

Sorry, I misunderstood your proposal. Regardless, I think the point still 
remains - it seems a shame to have to update all of the DN configs when doing 
an upgrade in order to allow for rolling upgrade. I think it also implies that 
the user should again update all of the DN configs after the rolling upgrade is 
completed to remove the entry for the other acceptable version. It seems better 
to me to just check the major/minor (or just major?) version numbers, than 
require these conf changes.

Does that make sense?

bq. This also prevents accidentally upgrade to a different version.

Does it? Unless I'm still misunderstanding you, if the version we're currently 
running is X, but we want to do a rolling upgrade to Y, I think we'd have to 
put "X" in the DN configs. The upgraded DNs will know that they're version Y, 
but they will have to know to accept a response from NN which is still running 
version X.
                
> Relax the build version check to permit rolling upgrades within a release
> -------------------------------------------------------------------------
>
>                 Key: HDFS-2983
>                 URL: https://issues.apache.org/jira/browse/HDFS-2983
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: Eli Collins
>            Assignee: Aaron T. Myers
>         Attachments: HDFS-2983.patch
>
>
> Currently the version check for DN/NN communication is strict (it checks the 
> exact svn revision or git hash, Storage#getBuildVersion calls 
> VersionInfo#getRevision), which prevents rolling upgrades across any 
> releases. Once we have the PB-base RPC in place (coming soon to branch-23) 
> we'll have the necessary pieces in place to loosen this restriction, though 
> perhaps it takes another 23 minor release or so before we're ready to commit 
> to making the minor versions compatible.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to