[
https://issues.apache.org/jira/browse/HDFS-2983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250211#comment-13250211
]
Todd Lipcon commented on HDFS-2983:
-----------------------------------
{code}
+ if (!dnVersion.equals(nnVersion)) {
+ LOG.info("Reported DataNode version '" + dnVersion + "' does not match "
+
+ "NameNode version '" + nnVersion + "' but is within acceptable " +
+ "limits. Note: This is normal during a rolling upgrade.");
+ }
{code}
Can you also please include the DN IP address in this log message?
----
- Nice lengthy javadoc on VersionUtil.compareVersions. Can you please add
something like:
"This method of comparison is similar to the method used by package versioning
systems like deb and RPM"
and also maybe give one example of what you mean? eg add "For example, Hadoop
0.3 < Hadoop 0.20 even though naive string comparison would consider it larger."
Otherwise, looks great. +1 from my standpoint. Konstantin/Sanjay - can you
please comment regarding the above discussion? While I agree that there are
more improvements to be made, I don't think this patch will hurt things. Or, if
you are nervous about it, can we commit this with a flag to allow rolling
upgrade if the operator permits it?
> Relax the build version check to permit rolling upgrades within a release
> -------------------------------------------------------------------------
>
> Key: HDFS-2983
> URL: https://issues.apache.org/jira/browse/HDFS-2983
> Project: Hadoop HDFS
> Issue Type: Improvement
> Affects Versions: 2.0.0
> Reporter: Eli Collins
> Assignee: Aaron T. Myers
> Attachments: HDFS-2983.patch, HDFS-2983.patch, HDFS-2983.patch,
> HDFS-2983.patch, HDFS-2983.patch, HDFS-2983.patch
>
>
> Currently the version check for DN/NN communication is strict (it checks the
> exact svn revision or git hash, Storage#getBuildVersion calls
> VersionInfo#getRevision), which prevents rolling upgrades across any
> releases. Once we have the PB-base RPC in place (coming soon to branch-23)
> we'll have the necessary pieces in place to loosen this restriction, though
> perhaps it takes another 23 minor release or so before we're ready to commit
> to making the minor versions compatible.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
