[
https://issues.apache.org/jira/browse/HDFS-3196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13253062#comment-13253062
]
Suresh Srinivas commented on HDFS-3196:
---------------------------------------
Comments:
# JournalDiskWriter
#* Looks like it is incomplete. Please add TODO items at least.
#* When is editlog instantiated, you need directories where editlogs are
written etc. Currently editlog is null.
#* Please add tests for JournalDiskWriter.
# I had renamed
# Unrelated to this patch, can you remove unneccessary IOException thrown frmo
FSEditLog#namenodeStartedLogSegment.
# I prefer calling namenodeStartedLogSegment to startLogSegment and indicate in
the comments that the remote namenode started a new log segment.
I like the idea of refactoring the code in trunk first and bringing it in.
> Implement JournalListener for writing journal to local disk
> -----------------------------------------------------------
>
> Key: HDFS-3196
> URL: https://issues.apache.org/jira/browse/HDFS-3196
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha, name-node
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: h3196_20120412.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
