[ 
https://issues.apache.org/jira/browse/HDFS-3279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254171#comment-13254171
 ] 

Hadoop QA commented on HDFS-3279:
---------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12522683/HDFS-3279.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 1 new or modified test 
files.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) 
warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 core tests.  The patch passed unit tests in .

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HDFS-Build/2278//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2278//console

This message is automatically generated.
                
> One of the FSEditLog constructor should be moved to TestEditLog
> ---------------------------------------------------------------
>
>                 Key: HDFS-3279
>                 URL: https://issues.apache.org/jira/browse/HDFS-3279
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>    Affects Versions: 3.0.0
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Arpit Gupta
>            Priority: Minor
>         Attachments: HDFS-3279.patch
>
>
> The FSEditLog constructor with @VisibleForTesting is used only in 
> TestEditLog.  It could be simply declared as a static method in TestEditLog.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to