[ https://issues.apache.org/jira/browse/HDFS-3275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13255637#comment-13255637 ]
amith commented on HDFS-3275: ----------------------------- I agree with uma. Currently I have created a patch which work with shared dir configured with file protocol. If any bookeeper related directory is configured then my patch will not fail the format. {code} for(Iterator<URI> it = dirsToFormat.iterator(); it.hasNext();) { File curDir = new File(it.next().getPath()); // Its alright for a dir not to exist, or to exist (properly accessible) // and be completely empty. if (!curDir.exists() || (curDir.isDirectory() && FileUtil.listFiles(curDir).length == 0)) continue; {code} curDir.exist() (which will check locally and return false) and user is not prompted for formatting this shared dir. I have another doubt If I format the HDFS cluster which used Bookeeper for shared storage, then ./hdfs namenode -format will not format the shared dir(bookeeper dir). Then how cluster works with older version details? > Format command overwrites contents of non-empty shared edits dir if name dirs > are empty without any prompting > ------------------------------------------------------------------------------------------------------------- > > Key: HDFS-3275 > URL: https://issues.apache.org/jira/browse/HDFS-3275 > Project: Hadoop HDFS > Issue Type: Bug > Components: ha, name-node > Affects Versions: 2.0.0 > Reporter: Vinithra Varadharajan > Assignee: amith > > To reproduce: > # Configure a NameNode with namedirs and a shared edits dir, all of which are > empty. > # Run hdfs namenode -format. Namedirs and shared edits dir gets populated. > # Delete the contents of the namedirs. Leave the shared edits dir as is. > Check the timestamps of the shared edits dir contents. > # Run format again. The namedirs as well as the shared edits dir get > formatted. The shared edits dir's contents have been replaced without any > prompting. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira