[ https://issues.apache.org/jira/browse/HDFS-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257136#comment-13257136 ]
Tsz Wo (Nicholas), SZE commented on HDFS-3201: ---------------------------------------------- - You are actually using DFS_JOURNAL_USER_NAME_KEY in the code, please update the TODO. {code} + // TODO: journal service should use DFS_JOURNAL_USER_NAME_KEY when security is + // enabled {code} - Please remove Journal.getStorageInfo() - Please use JOURNAL_ATTRIBUTE_KEY {code} + httpServer.setAttribute("localjournal", localJournal); {code} - Move editsToDownload(..) to the test since it is only used there. > Implement Journal reader for reading transactions from local edits log or > remote Journal node > --------------------------------------------------------------------------------------------- > > Key: HDFS-3201 > URL: https://issues.apache.org/jira/browse/HDFS-3201 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: ha, name-node > Reporter: Brandon Li > Assignee: Brandon Li > Attachments: HDFS-3201.HDFS-3092.patch, HDFS-3201.HDFS-3092.patch, > HDFS-3201.HDFS-3092.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira