[ 
https://issues.apache.org/jira/browse/HDFS-3275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13260868#comment-13260868
 ] 

Hadoop QA commented on HDFS-3275:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12524019/HDFS-3275_3.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 2 new or modified test 
files.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) 
warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    -1 core tests.  The patch failed these unit tests:
                  org.apache.hadoop.hdfs.server.namenode.ha.TestHAWebUI
                  org.apache.hadoop.hdfs.TestDFSClientFailover
                  org.apache.hadoop.hdfs.server.namenode.TestEditLogRace
                  
org.apache.hadoop.hdfs.server.namenode.TestNNThroughputBenchmark
                  org.apache.hadoop.hdfs.server.namenode.TestStartup
                  org.apache.hadoop.hdfs.server.namenode.ha.TestNNHealthCheck
                  
org.apache.hadoop.hdfs.server.namenode.ha.TestInitializeSharedEdits
                  
org.apache.hadoop.hdfs.server.namenode.ha.TestHAStateTransitions
                  org.apache.hadoop.hdfs.server.namenode.ha.TestGetGroupsWithHA
                  org.apache.hadoop.hdfs.server.namenode.TestNameEditsConfigs
                  
org.apache.hadoop.hdfs.server.namenode.ha.TestEditLogsDuringFailover
                  org.apache.hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA
                  org.apache.hadoop.hdfs.server.namenode.ha.TestHAFsck
                  org.apache.hadoop.hdfs.TestDFSUpgrade
                  org.apache.hadoop.hdfs.server.namenode.ha.TestBootstrapStandby
                  org.apache.hadoop.hdfs.TestDFSStorageStateRecovery
                  org.apache.hadoop.hdfs.server.namenode.ha.TestStandbyIsHot
                  org.apache.hadoop.hdfs.server.namenode.TestCheckpoint
                  
org.apache.hadoop.hdfs.server.namenode.ha.TestDelegationTokensWithHA
                  
org.apache.hadoop.hdfs.server.blockmanagement.TestReplicationPolicy
                  org.apache.hadoop.hdfs.TestDFSRollback
                  
org.apache.hadoop.hdfs.server.namenode.ha.TestFailureOfSharedDir
                  
org.apache.hadoop.hdfs.server.namenode.ha.TestDNFencingWithReplication
                  org.apache.hadoop.hdfs.server.namenode.ha.TestHAMetrics
                  org.apache.hadoop.hdfs.server.namenode.ha.TestQuotasWithHA
                  org.apache.hadoop.hdfs.TestDatanodeBlockScanner
                  
org.apache.hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints
                  
org.apache.hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes
                  org.apache.hadoop.hdfs.server.namenode.ha.TestHASafeMode
                  
org.apache.hadoop.hdfs.server.namenode.ha.TestPipelinesFailover
                  org.apache.hadoop.hdfs.TestDFSFinalize
                  
org.apache.hadoop.hdfs.server.namenode.TestValidateConfigurationSettings
                  org.apache.hadoop.hdfs.server.namenode.ha.TestEditLogTailer
                  org.apache.hadoop.hdfs.TestDFSStartupVersions
                  org.apache.hadoop.hdfs.tools.TestDFSHAAdminMiniCluster
                  org.apache.hadoop.hdfs.TestHDFSServerPorts
                  
org.apache.hadoop.hdfs.server.namenode.ha.TestHarFileSystemWithHA
                  
org.apache.hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits
                  org.apache.hadoop.hdfs.server.namenode.ha.TestDNFencing
                  
org.apache.hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer
                  org.apache.hadoop.hdfs.server.namenode.TestClusterId

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HDFS-Build/2322//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2322//console

This message is automatically generated.
                
> Format command overwrites contents of non-empty shared edits dir if name dirs 
> are empty without any prompting
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-3275
>                 URL: https://issues.apache.org/jira/browse/HDFS-3275
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: ha, name-node
>    Affects Versions: 2.0.0
>            Reporter: Vinithra Varadharajan
>            Assignee: amith
>             Fix For: 3.0.0
>
>         Attachments: HDFS-3275.patch, HDFS-3275_1.patch, HDFS-3275_1.patch, 
> HDFS-3275_2.patch, HDFS-3275_2.patch, HDFS-3275_3.patch
>
>
> To reproduce:
> # Configure a NameNode with namedirs and a shared edits dir, all of which are 
> empty.
> # Run hdfs namenode -format. Namedirs and shared edits dir gets populated.
> # Delete the contents of the namedirs. Leave the shared edits dir as is. 
> Check the timestamps of the shared edits dir contents.
> # Run format again. The namedirs as well as the shared edits dir get 
> formatted. The shared edits dir's contents have been replaced without any 
> prompting.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to