[ 
https://issues.apache.org/jira/browse/HDFS-3336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13265946#comment-13265946
 ] 

Hadoop QA commented on HDFS-3336:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12525182/HDFS-3336.patch.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified 
tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    -1 javadoc.  The javadoc tool appears to have generated 16 warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) 
warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 core tests.  The patch passed unit tests in 
hadoop-hdfs-project/hadoop-hdfs.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HDFS-Build/2353//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2353//console

This message is automatically generated.
                
> hdfs launcher script will be better off not special casing namenode command 
> with regards to hadoop.security.logger
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-3336
>                 URL: https://issues.apache.org/jira/browse/HDFS-3336
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 0.23.1
>            Reporter: Roman Shaposhnik
>            Assignee: Roman Shaposhnik
>            Priority: Minor
>             Fix For: 2.0.0
>
>         Attachments: HDFS-3336.patch.txt
>
>
> All of the launcher scripts (except hdfs when called with a namenode 
> argument) are defaulting to INFO,NullAppender setting for 
> hadoop.security.logger. The only codepath where the default is INFO,RFAS is 
> via hadoop-daemon.sh. This is exactly the right thing to do since only 
> daemons are guaranteed to be executed under the proper user account (the one 
> that has write/create access to the locations specified in 
> ${hadoop.log.dir}/*).
> It would be nice for 'hdfs namenode' to follow the suit and not produce 
> spurious warnings about not being able to write to log locations when 
> executed from under regular accounts.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to