[
https://issues.apache.org/jira/browse/HDFS-3186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266965#comment-13266965
]
Suresh Srinivas commented on HDFS-3186:
---------------------------------------
Preliminary comments:
# JournalService.java
#* JournalSync conf should be renamed as it hides outer class conf.
#* Remove unnecessary casting 3 to long
#* In startLogSegment the comment you have added is unnecessary
#* Why do you want to throw IllegalStateException in inSync() method?
#* Update the JournalService constructor javadoc for newly added parameters
#* Why should syncThread be a never ending thread?
#* There are bunch of TODO items
#* Why would syncThread be not null in run() method?
#* Please use space after // in comments. Also for method comments use /** */
comments.
#* runSync - startSync name better? valueSet may not be needed?
#* enableRunSync() - startSync() better name?
#* getRunSync() - waitForStartSync() better name?
#* Add javadoc to JouranalSync methods
#* rename getAllJournalSegments to syncAllJournalSegments?
#* "Sync trial failed for" to "Sync failed for"
> Sync lagging journal service from the active journal service
> ------------------------------------------------------------
>
> Key: HDFS-3186
> URL: https://issues.apache.org/jira/browse/HDFS-3186
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha, name-node
> Reporter: Hari Mankude
> Assignee: Brandon Li
> Attachments: HDFS-3186.HDFS-3092.patch, HDFS-3186.HDFS-3092.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
