[ 
https://issues.apache.org/jira/browse/HDFS-3330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13267095#comment-13267095
 ] 

Todd Lipcon commented on HDFS-3330:
-----------------------------------

This does appear to affect branch-1. Does anyone mind if I just commit the fix 
(change the catch clause to catch all Throwable) without the tests in branch-1? 
TestCheckpoint is substantially different.
                
> If GetImageServlet throws an Error or RTE, response has HTTP "OK" status
> ------------------------------------------------------------------------
>
>                 Key: HDFS-3330
>                 URL: https://issues.apache.org/jira/browse/HDFS-3330
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 1.0.0, 2.0.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Critical
>             Fix For: 2.0.0
>
>         Attachments: hdfs-3330.txt
>
>
> Currently in GetImageServlet, we catch Exception but not other Errors or 
> RTEs. So, if the code ends up throwing one of these exceptions, the 
> "response.sendError()" code doesn't run, but the finally clause does run. 
> This results in the servlet returning HTTP 200 OK and an empty response, 
> which causes the client to think it got a successful image transfer.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to