[ https://issues.apache.org/jira/browse/HDFS-3335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272808#comment-13272808 ]
Hadoop QA commented on HDFS-3335: --------------------------------- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12526396/HDFS-3335.007.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified test files. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2411//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2411//console This message is automatically generated. > check for edit log corruption at the end of the log > --------------------------------------------------- > > Key: HDFS-3335 > URL: https://issues.apache.org/jira/browse/HDFS-3335 > Project: Hadoop HDFS > Issue Type: Improvement > Affects Versions: 0.23.0 > Reporter: Colin Patrick McCabe > Assignee: Colin Patrick McCabe > Attachments: HDFS-3335-b1.001.patch, HDFS-3335-b1.002.patch, > HDFS-3335-b1.003.patch, HDFS-3335.001.patch, HDFS-3335.002.patch, > HDFS-3335.003.patch, HDFS-3335.004.patch, HDFS-3335.005.patch, > HDFS-3335.006.patch, HDFS-3335.007.patch > > > Even after encountering an OP_INVALID, we should check the end of the edit > log to make sure that it contains no more edits. > This will catch things like rare race conditions or log corruptions that > would otherwise remain undetected. They will got from being silent data loss > scenarios to being cases that we can detect and fix. > Using recovery mode, we can choose to ignore the end of the log if necessary. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira