[ 
https://issues.apache.org/jira/browse/HDFS-3415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13279388#comment-13279388
 ] 

Tsz Wo (Nicholas), SZE commented on HDFS-3415:
----------------------------------------------

I actually want you remove the min and max computation since it does not make 
sense to compute min and max for checking equality.  It is okay if you don't 
want to.  However, please remove "if (minLayoutVersion > maxLayoutVersion) 
{..}".

You should use StringBuilder instead of String as indicated by [the new 
findbugs 
warning|https://builds.apache.org/job/PreCommit-HDFS-Build/2484/artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html].
                
> During NameNode starting up, it may pick wrong storage directory inspector 
> when the layout versions of the storage directories are different
> --------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-3415
>                 URL: https://issues.apache.org/jira/browse/HDFS-3415
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 2.0.0, 3.0.0
>         Environment: Suse linux + jdk 1.6
>            Reporter: Brahma Reddy Battula
>            Assignee: Brandon Li
>         Attachments: HDFS-3415.patch, HDFS-3415.patch
>
>
> Scenario:
> =========
> start Namenode and datanode by configuring three storage dir's for namenode
> write 10 files
> edit version file of one of the storage dir and give layout version as 123 
> which different with default(-40).
> Stop namenode
> start Namenode.
> Then I am getting follwong exception...
> {noformat}
> 2012-05-13 19:01:41,483 ERROR 
> org.apache.hadoop.hdfs.server.namenode.NameNode: Exception in namenode join
> java.lang.NullPointerException
>       at 
> org.apache.hadoop.hdfs.server.namenode.NNStorage.getStorageFile(NNStorage.java:686)
>       at 
> org.apache.hadoop.hdfs.server.namenode.FSImagePreTransactionalStorageInspector.getEditsInStorageDir(FSImagePreTransactionalStorageInspector.java:243)
>       at 
> org.apache.hadoop.hdfs.server.namenode.FSImagePreTransactionalStorageInspector.getLatestEditsFiles(FSImagePreTransactionalStorageInspector.java:261)
>       at 
> org.apache.hadoop.hdfs.server.namenode.FSImagePreTransactionalStorageInspector.getEditLogStreams(FSImagePreTransactionalStorageInspector.java:276)
>       at 
> org.apache.hadoop.hdfs.server.namenode.FSImage.loadFSImage(FSImage.java:596)
>       at 
> org.apache.hadoop.hdfs.server.namenode.FSImage.recoverTransitionRead(FSImage.java:247)
>       at 
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem.loadFSImage(FSNamesystem.java:498)
>       at 
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem.loadFromDisk(FSNamesystem.java:390)
>       at 
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem.loadFromDisk(FSNamesystem.java:354)
>       at 
> org.apache.hadoop.hdfs.server.namenode.NameNode.loadNamesystem(NameNode.java:368)
>       at 
> org.apache.hadoop.hdfs.server.namenode.NameNode.initialize(NameNode.java:402)
>       at 
> org.apache.hadoop.hdfs.server.namenode.NameNode.<init>(NameNode.java:564)
>       at 
> org.apache.hadoop.hdfs.server.namenode.NameNode.<init>(NameNode.java:545)
>       at 
> org.apache.hadoop.hdfs.server.namenode.NameNode.createNameNode(NameNode.java:1093)
>       at 
> org.apache.hadoop.hdfs.server.namenode.NameNode.main(NameNode.java:1151)
> 2012-05-13 19:01:41,485 INFO org.apache.hadoop.hdfs.server.namenode.NameNode: 
> SHUTDOWN_MSG: 
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to