[
https://issues.apache.org/jira/browse/HDFS-3508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13292111#comment-13292111
]
Eli Collins commented on HDFS-3508:
-----------------------------------
Nit: please use assertTrue/assertFalse instead of "assertEquals(bool".
We're already using Text.ONE_MEGABYTE, this change uses per-field MAX
variables, rather than having multiple ways of doing this let's just replace
Text.ONE_MEGABYTE with Text.MAX_LEN and use it everywhere. I think it's fine to
share a max length as we're not trying to validate a per-field max, we're just
trying to detect bogus values, eg due to missing or corrupt fields, so it's ok
to share one limit even though the fields may have different limits in practice.
(Btw here and HADOOP-8361 the length really isn't a max length, the max length
normally means the max we'll tolerate, here we'll blow up if == max length. Not
a big deal since these maxes won't be used in practice.)
> avoid OOM while deserializing DelegationTokenIdentifer
> ------------------------------------------------------
>
> Key: HDFS-3508
> URL: https://issues.apache.org/jira/browse/HDFS-3508
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 2.0.0-alpha
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Fix For: 2.0.1-alpha
>
> Attachments: HDFS-3508.001.patch, HDFS-3508.002.patch,
> HDFS-3508.003.patch
>
>
> avoid OOM while deserializing DelegationTokenIdentifer
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
