[ 
https://issues.apache.org/jira/browse/HDFS-3490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tsz Wo (Nicholas), SZE updated HDFS-3490:
-----------------------------------------

    Description: If NamenodeRpcAddressParam is not passed to the datanode 
webhdfs methods, an NPE will be generated trying to use it. We should check the 
parameter and throw a more appropriate error message when it is missing.  (was: 
Currently, there is no validation done on the NamenodeRpcAddressParam. If it is 
not passed to the datanode webhdfs methods, an NPE will be generated trying to 
use it. We should instead have some kind of validation on the parameter and 
throw a more appropriate error message when it is missing.)

Todd, thanks for the review!

We indeed already have validation in InetSocketAddressParam which is the super 
class of NamenodeRpcAddressParam.  Revised description.
                
> DN WebHDFS methods throw NPE if Namenode RPC address param not specified
> ------------------------------------------------------------------------
>
>                 Key: HDFS-3490
>                 URL: https://issues.apache.org/jira/browse/HDFS-3490
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: data-node
>    Affects Versions: 2.0.0-alpha
>            Reporter: Todd Lipcon
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Minor
>         Attachments: h3490_20120605.patch, h3490_20120606.patch
>
>
> If NamenodeRpcAddressParam is not passed to the datanode webhdfs methods, an 
> NPE will be generated trying to use it. We should check the parameter and 
> throw a more appropriate error message when it is missing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to