[ 
https://issues.apache.org/jira/browse/HDFS-3540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13295955#comment-13295955
 ] 

Colin Patrick McCabe commented on HDFS-3540:
--------------------------------------------

bq. Let's keep our discussion on JIRA so that other people could comment on it. 
I have filed HDFS-3540 for this purpose.

Ok. Since I noticed that there are a bunch of people watching HDFS-3521, but 
nobody watching HDFS-3540 (yet?), I hope you don't mind if I repost this 
comment twice. I do apologize for the potential inbox spam.

I think rather than tolerating a configurable amount of edit log corruption, we 
should just never tolerate any corruption.

Basically, what I am saying is that UNCHECKED_REGION_LENGTH was a mistake. It 
was my mistake, and I don't blame you for trying to fix it. However, the 
current fix still assumes that there is someone who would want 
UNCHECKED_REGION_LENGTH. I do not think any people like that exist!

Does that make sense? I can post a patch if that would be helpful.
                
> Further improvement on recovery mode and edit log toleration in branch-1
> ------------------------------------------------------------------------
>
>                 Key: HDFS-3540
>                 URL: https://issues.apache.org/jira/browse/HDFS-3540
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 1.2.0
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>
> *Recovery Mode*: HDFS-3479 backported HDFS-3335 to branch-1.  However, the 
> recovery mode feature in branch-1 is dramatically different from the recovery 
> mode in trunk since the edit log implementations in these two branch are 
> different.  For example, there is UNCHECKED_REGION_LENGTH in branch-1 but not 
> in trunk.
> *Edit Log Toleration*: HDFS-3521 added this feature to branch-1 to remedy 
> UNCHECKED_REGION_LENGTH and to tolerate edit log corruption.
> There are overlaps between these two features.  We study potential further 
> improvement in this issue.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to