[ https://issues.apache.org/jira/browse/HDFS-3498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13397253#comment-13397253 ]
Hadoop QA commented on HDFS-3498: --------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12532640/HDFS-3498-v2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 javadoc. The javadoc tool appears to have generated 13 warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2672//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2672//console This message is automatically generated. > Make ReplicaPlacementPolicyDefault extensible for reuse code in subclass > ------------------------------------------------------------------------ > > Key: HDFS-3498 > URL: https://issues.apache.org/jira/browse/HDFS-3498 > Project: Hadoop HDFS > Issue Type: Bug > Components: data-node > Affects Versions: 1.0.0, 2.0.0-alpha > Reporter: Junping Du > Assignee: Junping Du > Attachments: HDFS-3498-v2.patch, HDFS-3498.patch, > Hadoop-8471-BlockPlacementDefault-extensible.patch > > > ReplicaPlacementPolicy is already a pluggable component in Hadoop. A user > specified ReplicaPlacementPolicy can be specified in the hdfs-site.xml > configuration under the key "dfs.block.replicator.classname". However, to > make it possible to reuse code in ReplicaPlacementPolicyDefault a few of its > methods were changed from private to protected. ReplicaPlacementPolicy and > BlockPlacementPolicyDefault are currently annotated with > @InterfaceAudience.Private. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira