[ https://issues.apache.org/jira/browse/HDFS-3541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400888#comment-13400888 ]
Aaron T. Myers commented on HDFS-3541: -------------------------------------- Patch looks pretty good to me. Just two small comments: # Misspelled "interrupted": "Finalizing block from Inturrupted thread should fail" # This chunk of code confuses me, since you don't use {{written}} again after the loop, and there doesn't seem to be any need to call {{write(...)}} many times: {code} + int written = 0; + for (; written < 512;) { + out.writeBytes(data); + written += 4; + } {code} Kihwal, how does this patch look to you? > Deadlock between recovery, xceiver and packet responder > ------------------------------------------------------- > > Key: HDFS-3541 > URL: https://issues.apache.org/jira/browse/HDFS-3541 > Project: Hadoop HDFS > Issue Type: Bug > Components: data-node > Affects Versions: 0.23.3, 2.0.1-alpha > Reporter: suja s > Assignee: Vinay > Attachments: DN_dump.rar, HDFS-3541.patch > > > Block Recovery initiated while write in progress at Datanode side. Found a > lock between recovery, xceiver and packet responder. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira