[
https://issues.apache.org/jira/browse/HDFS-3190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403616#comment-13403616
]
Suresh Srinivas commented on HDFS-3190:
---------------------------------------
Nice refactoring. +1 for the patch with some minor comments:
# Some lines are over 80 chars.
# StorageErrorReporter.java
#* StorageErrorReporter javadoc - can you please add link to JournalManager. I
am not very clear on what you mean by "central manager of storage directory
state".
#* Also can you please add javadoc description to the methods
# PersistentLong - PersistentLongFile or AtomicLongFile better name?
> Simple refactors in existing NN code to assist QuorumJournalManager extension
> -----------------------------------------------------------------------------
>
> Key: HDFS-3190
> URL: https://issues.apache.org/jira/browse/HDFS-3190
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: name-node
> Affects Versions: 2.0.0-alpha
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Attachments: hdfs-3190.txt, hdfs-3190.txt, hdfs-3190.txt,
> hdfs-3190.txt
>
>
> This JIRA is for some simple refactors in the NN:
> - refactor the code which writes the seen_txid file in NNStorage into a new
> "LongContainingFile" utility class. This is useful for the JournalNode to
> atomically/durably record its last promised epoch
> - refactor the interface from FileJournalManager back to StorageDirectory to
> use a StorageErrorReport interface. This allows FileJournalManager to be used
> in isolation of a full StorageDirectory.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
