[
https://issues.apache.org/jira/browse/HDFS-3612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13412481#comment-13412481
]
Harsh J commented on HDFS-3612:
-------------------------------
Andy,
Yeah I missed that the other said edits, my bad.
Your fixes look good to me, can you address the couple of nits if you agree?:
# Double space after the full-stop in the log message can be made to a single
one.
# When printing the config "dfs.namenode.*.dir" in each log line, perhaps lets
prefix a generalized role string, for clarity? Meaning something like:
{quote}
Only one image storage directory (dfs.namenode.name.dir) configured. Beware of
dataloss due to lack of redundant storage directories!
Only one namespace edits storage directory (dfs.namenode.edits.dir) configured.
Beware of dataloss due to lack of redundant storage directories!
{quote}
> Single namenode image directory config warning can be improved
> --------------------------------------------------------------
>
> Key: HDFS-3612
> URL: https://issues.apache.org/jira/browse/HDFS-3612
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: name-node
> Affects Versions: 2.0.0-alpha
> Reporter: Harsh J
> Assignee: Andy Isaacson
> Priority: Trivial
> Labels: newbie
> Attachments: hdfs3612.txt
>
>
> Currently, if you configure the NameNode to run with just one
> dfs.namenode.name.dir directory, it prints:
> {code}
> 12/07/08 20:00:22 WARN namenode.FSNamesystem: Only one dfs.namenode.name.dir
> directory configured , beware data loss!{code}
> We can improve this in a few ways as it is slightly ambiguous:
> # Fix punctuation spacing, there's always a space after a punctuation mark
> but never before one.
> # Perhaps the message is better printed with a reason of why it may cause a
> scare of data loss. For instance, we can print "Detected a single storage
> directory in dfs.namenode.name.dir configuration. Beware of dataloss due to
> lack of redundant storage directories" or so.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
