[ 
https://issues.apache.org/jira/browse/HDFS-3113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13417297#comment-13417297
 ] 

Eli Collins commented on HDFS-3113:
-----------------------------------

Hey Tucu,

Overall looks good, only minor comments follow.  What testing have you done 
with these patches, confirmed distcp against httpfs with kerberos enabled now 
works?

pom.xml
- Intend to comment out <forkMode> always?

ServerWebApp.java
- Annotate setAuthority VisibleForTesting?

HttpFSKerberosAuthenticator
- Why wrap AuthenticationException in IOEs for the token methods?

DelegationTokenManagerException 
- This class should be public / stable right?

HttpFSUtils
- Use HttpFSFileSystem.SCHEME

HttpFSKerberosAuthenticationHandler
- The last part of the authenticate javadoc is not filled out

NetUtils 
- The diff is a nop

                
> httpfs does not support delegation tokens
> -----------------------------------------
>
>                 Key: HDFS-3113
>                 URL: https://issues.apache.org/jira/browse/HDFS-3113
>             Project: Hadoop HDFS
>          Issue Type: New Feature
>    Affects Versions: 0.23.3
>            Reporter: Alejandro Abdelnur
>            Assignee: Alejandro Abdelnur
>             Fix For: 0.24.0, 0.23.3
>
>         Attachments: HDFS-3113.patch, HDFS-3113.patch, HDFS-3113.patch, 
> HDFS-3113.patch
>
>
> httpfs does not support calls to get/renew tokens nor delegation token 
> authentication.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to