[
https://issues.apache.org/jira/browse/HDFS-3723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13426207#comment-13426207
]
Aaron T. Myers commented on HDFS-3723:
--------------------------------------
Hi Jing Zhao, you should mark the patch "patch available" by clicking the
"Submit Patch" button so that the pre-commit Jenkins tests run.
I'll do that for you now.
> All commands should support meaningful --help
> ---------------------------------------------
>
> Key: HDFS-3723
> URL: https://issues.apache.org/jira/browse/HDFS-3723
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: scripts, tools
> Affects Versions: 2.0.0-alpha
> Reporter: E. Sammer
> Assignee: Jing Zhao
> Attachments: HDFS-3723.patch
>
>
> Some (sub)commands support -help or -h options for detailed help while others
> do not. Ideally, all commands should support meaningful help that works
> regardless of current state or configuration.
> For example, hdfs zkfc --help (or -h or -help) is not very useful. Option
> checking should occur before state / configuration checking.
> {code}
> [esammer@hadoop-fed01 ~]# hdfs zkfc --help
> Exception in thread "main" org.apache.hadoop.HadoopIllegalArgumentException:
> HA is not enabled for this namenode.
> at
> org.apache.hadoop.hdfs.tools.DFSZKFailoverController.setConf(DFSZKFailoverController.java:122)
> at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:66)
> at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:84)
> at
> org.apache.hadoop.hdfs.tools.DFSZKFailoverController.main(DFSZKFailoverController.java:168)
> {code}
> This would go a long way toward better usability for ops staff.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
