[ 
https://issues.apache.org/jira/browse/HDFS-3735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13427150#comment-13427150
 ] 

Brahma Reddy Battula commented on HDFS-3735:
--------------------------------------------

Hi Suresh,

Thanks for taking look,I have fixed and verified manually.It's working fine.
 
Added following in *JspHelper.java*  

 method : NodeComapare
{code}
        } else if (field.equals("bpused")) {
          sortField = FIELD_BP_USED;
        }else if (field.equals("pcbpused")) {
          sortField = FIELD_PERCENT_BP_USED;
        }else if (field.equals("volfails")) {
          sortField = FIELD_FAILED_VOL;
        }
{code}

 method : compare
{code}
 case FIELD_BP_USED:
          dlong = d1.getBlockPoolUsed() - d2.getBlockPoolUsed();
          ret = (dlong < 0) ? -1 : ((dlong > 0) ? 1 : 0);
          break;
        case FIELD_PERCENT_BP_USED:
           ddbl =((d1.getBlockPoolUsedPercent())-
                        (d2.getBlockPoolUsedPercent()));
          ret = (ddbl < 0) ? -1 : ((ddbl > 0) ? 1 : 0);
          break;
        case FIELD_FAILED_VOL:
          ret = d1.getVolumeFailures() - d2.getVolumeFailures();
          break;
{code}

Will post the patch once testcase written(need to write). 
                
> [ NNUI --> NNJspHelper.java ] Last three fields not considered for display 
> data in sorting
> ------------------------------------------------------------------------------------------
>
>                 Key: HDFS-3735
>                 URL: https://issues.apache.org/jira/browse/HDFS-3735
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 2.0.0-alpha, 2.0.1-alpha
>            Reporter: Brahma Reddy Battula
>            Priority: Minor
>
> Live datanode list is not correctly sorted for columns Block Pool Used (GB),
> Block Pool Used (%)  and Failed Volumes. Read comments for more details.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to