[ https://issues.apache.org/jira/browse/HDFS-3754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HDFS-3754: ------------------------------ Attachment: hdfs-3754-b1.txt Updated branch-1 patch. The fix for branch-1 also requires that the invocation of Executors#defaultThreadFactory be hoisted to the constructor, this is because the ThreadGroup used is that of the thread invoking defaultThreadFactory and we want that to be the primary thread group rather than the thread group of whatever thread causes the pool to create a new thread. Trunk doesn't have this problem because it uses guava's ThreadFactoryBuilder which behaves similarly (does not invoke defaultThreadFactory on each newThread call). Running {{ant test -Dtestcase=TestSeekBug -Dcompile.native=true}} no longer hangs with this patch. > BlockSender doesn't shutdown ReadaheadPool threads > -------------------------------------------------- > > Key: HDFS-3754 > URL: https://issues.apache.org/jira/browse/HDFS-3754 > Project: Hadoop HDFS > Issue Type: Bug > Components: data-node > Affects Versions: 1.2.0, 2.0.0-alpha > Reporter: Eli Collins > Assignee: Eli Collins > Fix For: 2.2.0-alpha > > Attachments: hdfs-3754-b1.txt, hdfs-3754-b1.txt, hdfs-3754.txt, > hdfs-3754.txt, hdfs-3754.txt, hdfs-3754.txt, hdfs-3754.txt, hdfs-3754.txt, > hdfs-3754.txt > > > The BlockSender doesn't shutdown the ReadaheadPool threads so when tests are > run with native libraries some tests fail (time out) because shutdown hangs > waiting for the outstanding threads to exit. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira