[
https://issues.apache.org/jira/browse/HDFS-3789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13433126#comment-13433126
]
Hadoop QA commented on HDFS-3789:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12540641/HDFS-3789.diff
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified test
files.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
-1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs
hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal:
org.apache.hadoop.hdfs.TestDFSClientRetries
org.apache.hadoop.hdfs.TestFileAppend4
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/2989//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HDFS-Build/2989//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2989//console
This message is automatically generated.
> JournalManager#format() should be able to throw IOException
> -----------------------------------------------------------
>
> Key: HDFS-3789
> URL: https://issues.apache.org/jira/browse/HDFS-3789
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha, name-node
> Affects Versions: 3.0.0
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Attachments: HDFS-3789.diff
>
>
> Currently JournalManager#format cannot throw any exception. As format can
> fail, we should be able to propogate this failure upwards. Otherwise, format
> will fail silently, and the admin will start using the cluster with a
> failed/unusable journal manager.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
