[ 
https://issues.apache.org/jira/browse/HDFS-3276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13433539#comment-13433539
 ] 

Todd Lipcon commented on HDFS-3276:
-----------------------------------

The two new findbugs warnings are HDFS-3792 - not caused by this patch.

bq. -1 tests included. The patch doesn't appear to include any new or modified 
tests.

There are no new tests since this is just hooking up existing code (which is 
tested in TestInitializeSharedEdits) to command line flags. I manually tested 
the command line flags and verified they perform as expected.
                
> initializeSharedEdits should have a -nonInteractive flag
> --------------------------------------------------------
>
>                 Key: HDFS-3276
>                 URL: https://issues.apache.org/jira/browse/HDFS-3276
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: ha, name-node
>    Affects Versions: 2.0.0-alpha
>            Reporter: Vinithra Varadharajan
>            Assignee: Todd Lipcon
>            Priority: Minor
>         Attachments: hdfs-3276.txt
>
>
> Similar to format and bootstrapStandby, would be nice to have -nonInteractive 
> as an option on initializeSharedEdits

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to